Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bundle size: calculate diff from PR base instead of main #2910

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Jul 31, 2024

Motivation

I'm doing PRs to the v6 feature branch, however the bundle size comment on the PR ar comparing to the main branch instead of the base branch of the PR.

Changes

Calculate the size difference using the PR's base branch instead of the main branch

Testing

see this PR for an example in actions

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@thomas-lebeau thomas-lebeau marked this pull request as ready for review July 31, 2024 14:57
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner July 31, 2024 14:57
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 159.13 KiB 159.13 KiB 0 B 0.00%
Logs 55.79 KiB 55.79 KiB 0 B 0.00%
Rum Slim 107.73 KiB 107.73 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.000
addaction 0.030 0.034 0.004
adderror 0.030 0.041 0.011
addtiming 0.001 0.001 0.000
startview 0.863 1.102 0.239
startstopsessionreplayrecording 0.769 0.983 0.214
logmessage 0.019 0.022 0.003
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 20.87 KiB 20.32 KiB -560 B
addaction 70.61 KiB 71.63 KiB 1.02 KiB
adderror 85.40 KiB 85.79 KiB 403 B
addtiming 17.95 KiB 18.64 KiB 710 B
startview 347.42 KiB 351.25 KiB 3.83 KiB
startstopsessionreplayrecording 14.48 KiB 13.72 KiB -776 B
logmessage 68.69 KiB 68.79 KiB 100 B

🔗 RealWorld

@thomas-lebeau thomas-lebeau merged commit a131fb7 into main Jul 31, 2024
20 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/bundle-size-diff-base-branch branch July 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants