🐛 fix unexpected exception when no entry type is supported in PerformanceObserver #2899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following #2855 and #2818, we are using more granular PerformanceObserver. We observe less entry types in the PerformanceObserver from
performanceCollection
, and in the newperformanceObservable
, we observe a single type at once.We observed that in old versions of Safari, if all entry types supplied to
.observe(..)
are unsupported, an exception is thrown:entryTypes contained only unsupported types
. Illustration:Changes
To work around this issue, this PR wraps
.observe(..)
calls intry/catch
blocks to prevent the SDK from crashing.Testing
I have gone over the contributing documentation.