🔉 [RUM-253] adjust heavy customer data warning when compression is enabled #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a single component used by both feature flags and context manager.
No need to test for customer data warning in every spec, move related tests to `trackCustomerData` spec.
This allows to reuse the same customerDataTracker in the "stored context manager" logic, so we don't show the same warning twice. It simplifies a bit the code.
Have a bigger limit when the compression is enabled. Because the compression "status" is only known at init, we need to wait until before showing the warning.
BenoitZugmeyer
force-pushed
the
benoit/compression--adjust-customer-warning-2
branch
from
6047511 to
03533c0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
==========================================
- Coverage 93.12% 93.07% -0.06%
==========================================
Files 227 227
Lines 6693 6710 +17
Branches 1466 1467 +1
==========================================
+ Hits 6233 6245 +12
- Misses 460 465 +5 ☔ View full report in Codecov by Sentry. |
BenoitZugmeyer
changed the title
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 3s Commit 03533c0c5d will soon be integrated into staging-50. This build is going to start soon! (estimated merge in less than 3s) you can cancel this operation by commenting your pull request with |
dd-mergequeue bot
added a commit
that referenced
this pull request
Dec 14, 2023
…rning-2 into staging-50 Co-authored-by: Benoît Zugmeyer <[email protected]>
|
🚂 Branch Integration: This commit was successfully integrated Commit 03533c0c5d has been merged into staging-50 in merge commit 2a0aaef68f. Check out the triggered pipeline on Gitlab 🦊 |
1 task
bcaudan
reviewed
Dec 21, 2023
amortemousque
approved these changes
Jan 9, 2024
bcaudan
approved these changes
Jan 9, 2024
BenoitZugmeyer
deleted the
benoit/compression--adjust-customer-warning-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are currently displaying a warning in the console when a large context (global context, user, log context) or a lot of feature flag evaluations are set. This is to encourage users to keep their setup lean to avoid impacting the bandwidth too much.
In #2500 we introduced a new initialization parameter to enable intake request compression. With this option enabled, we are able to send more data without impacting the bandwidth too much. Thus, we can now adapt the limit we currently use to display that warning.
Changes
Testing
I have gone over the contributing documentation.