-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUM-253] adapt transport to send encoded data #2415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
This was referenced Sep 5, 2023
bcaudan
approved these changes
Sep 6, 2023
amortemousque
approved these changes
Sep 7, 2023
In a next commit, the endpointBuilder will conditionally add a `dd-evp-encoding` URL parameter based on another payload property
e6fc07b
to
4fa98c7
Compare
ec86af6
to
5466106
Compare
Codecov Report
@@ Coverage Diff @@
## benoit/compress--add-deflate-worker-source #2415 +/- ##
===========================================================================
Coverage 93.94% 93.94%
===========================================================================
Files 221 221
Lines 6390 6391 +1
Branches 1410 1411 +1
===========================================================================
+ Hits 6003 6004 +1
Misses 387 387
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Base automatically changed from
benoit/compress--add-deflate-worker-source
to
main
September 15, 2023 13:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'll need to send the encoding as a new intake URL parameter.
Changes
Testing
I have gone over the contributing documentation.