Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUM-253] adapt transport to send encoded data #2415

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Sep 5, 2023

Motivation

We'll need to send the encoding as a new intake URL parameter.

Changes

  • Light refactoring
  • Add the ability to set the encoding through "payload" objects.

Testing


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 5, 2023 10:45
@BenoitZugmeyer
Copy link
Member Author

BenoitZugmeyer commented Sep 5, 2023

packages/core/src/transport/httpRequest.ts Outdated Show resolved Hide resolved
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--add-deflate-worker-source branch from e6fc07b to 4fa98c7 Compare September 11, 2023 14:12
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 11, 2023 14:12
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--adapt-transport branch from ec86af6 to 5466106 Compare September 11, 2023 14:12
@codecov-commenter
Copy link

Codecov Report

Merging #2415 (5466106) into benoit/compress--add-deflate-worker-source (4fa98c7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                             Coverage Diff                             @@
##           benoit/compress--add-deflate-worker-source    #2415   +/-   ##
===========================================================================
  Coverage                                       93.94%   93.94%           
===========================================================================
  Files                                             221      221           
  Lines                                            6390     6391    +1     
  Branches                                         1410     1411    +1     
===========================================================================
+ Hits                                             6003     6004    +1     
  Misses                                            387      387           
Files Changed Coverage Δ
...s/core/src/domain/configuration/endpointBuilder.ts 100.00% <100.00%> (ø)
packages/core/src/transport/httpRequest.ts 97.87% <100.00%> (-0.05%) ⬇️
packages/core/test/requests.ts 93.71% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from benoit/compress--add-deflate-worker-source to main September 15, 2023 13:54
@BenoitZugmeyer BenoitZugmeyer merged commit ed6db93 into main Sep 15, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/compress--adapt-transport branch September 15, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants