🔉 monitor reported errors #2335
Conversation
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 8m commit 5f49439bfe will soon be integrated into staging-28. This build is going to start soon! (estimated merge in less than 8m) you can cancel this operation by commenting your pull request with |
|
🚂 Branch Integration: this commit was successfully integrated commit 5f49439bfe has been merged into staging-28 in merge commit d4561f4392 |
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 8m commit fc9509a5f3 will soon be integrated into staging-28. This build is going to start soon! (estimated merge in less than 8m) you can cancel this operation by commenting your pull request with |
Codecov Report
@@ Coverage Diff @@
## main #2335 +/- ##
==========================================
- Coverage 94.20% 94.16% -0.05%
==========================================
Files 206 206
Lines 6128 6131 +3
Branches 1357 1357
==========================================
Hits 5773 5773
- Misses 355 358 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/to-staging -c |
|
🚂 Branch Integration: This merge request build was cancelled This merge request build was cancelled |
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 8m commit fc9509a5f3 will soon be integrated into staging-28. This build is going to start soon! (estimated merge in less than 8m) you can cancel this operation by commenting your pull request with |
|
(re queueing this pull request, this workflow was cancelled due to a temporal update) |
|
🚂 Branch Integration: this commit was successfully integrated commit fc9509a5f3 has been merged into staging-28 in merge commit 053a7d2aaa |
| @@ -51,6 +52,8 @@ export function startLogs( | |||
| status: StatusType.error, | |||
| }, | |||
| }) | |||
| addTelemetryDebug('Error reported to customer', { 'error.message': error.message }) | |||
There was a problem hiding this comment.
💬 suggestion: the three added telemetry logs are identical. Maybe add the error source in the context? It could be logs / rum / replay
There was a problem hiding this comment.
🤔 looking at the possible values of error.message and service, we should be able to identify exactly from where each log is coming.
Do you have a use case in mind that would benefit from adding this extra attribute?
There was a problem hiding this comment.
I don't! service is fine to distinghuish between RUM and Logs, but not replay. If you think we don't need to run some analytics between RUM and Replay, we can certainly rely on the message to figure out what was the source of the log.
There was a problem hiding this comment.
If you think we don't need to run some analytics between RUM and Replay, we can certainly rely on the message
That sounds fine for now, let's wait and see if we feel the need to add more context later
Motivation
Have an idea on how frequently we are reporting SDK errors to customers.
For now, we only report when:
Changes
Send telemetry debug when reporting an error
Testing
I have gone over the contributing documentation.