Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1534] send a view update when session is expiring #2166

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Apr 13, 2023

Motivation

Tell the backend to end the session early when we detect that the session expired, especially useful when using stopSession() manually.

Changes

With this PR, the SDK will send a view update with @session.is_active:false every time it detects that the session expires.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer changed the base branch from main to benoit/kiosk--allow-view-updates-after-session-expire April 13, 2023 18:36
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/kiosk--session-is-active-false branch from 9cfb822 to b18e89c Compare April 13, 2023 18:36
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Base automatically changed from benoit/kiosk--allow-view-updates-after-session-expire to main April 19, 2023 09:11
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/kiosk--session-is-active-false branch from b18e89c to 48a28d0 Compare April 19, 2023 09:26
@codecov-commenter
Copy link

Codecov Report

Merging #2166 (48a28d0) into main (7bd7a6e) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2166      +/-   ##
==========================================
+ Coverage   93.75%   93.87%   +0.11%     
==========================================
  Files         200      200              
  Lines        6102     6105       +3     
  Branches     1363     1366       +3     
==========================================
+ Hits         5721     5731      +10     
+ Misses        381      374       -7     
Impacted Files Coverage Δ
packages/rum-core/test/fixtures.ts 100.00% <ø> (ø)
.../src/domain/rumEventsCollection/view/trackViews.ts 100.00% <100.00%> (ø)
.../domain/rumEventsCollection/view/viewCollection.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review April 19, 2023 09:48
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner April 19, 2023 09:48
@BenoitZugmeyer BenoitZugmeyer merged commit cf429f8 into main Apr 20, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/kiosk--session-is-active-false branch April 20, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants