🏷️ improve addEventListener typings #2127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
improve addEventListener typings
Changes
Use TS "event map" to enforce stricter types and better type inference to
addEventListener
andaddEventListeners
functionsWith this change, we lose the required
DOM_EVENT.*
usage when usingaddEventListener
, meaning we can use"click"
instead ofDOM_EVENT.CLICK
. I didn't find a simple solution for both enforcing this and re-using TS event maps. I think this is an acceptable compromise. We might want to remove theDOM_EVENT
enum altogether, since it's no longer needed to enforce valid event names. Let's chat.Testing
I have gone over the contributing documentation.