♻️[RUMF-1517] reorganise some components

[bcaudan]

Motivation

Housekeeping + preventing potential cyclic dependencies

Changes

• move error to domain
• move eventRateLimiter to domain
• move runOnReadyState to browser
• move experimentalFeatures to tools
• move timer to tools

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[bcaudan]

Current dependencies on/for this PR:

• main
  • PR ♻️[RUMF-1517] reorganise some components #2124 👈
    • PR ♻️[RUMF-1517] split tools utils #2128
      • PR 👷[RUMF-1517] Add rule to disallow generic utils file name #2101

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Merging #2124 (44baad2) into main (c466c8f) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
+ Coverage   93.60%   93.64%   +0.03%     
==========================================
  Files         178      178              
  Lines        5976     5976              
  Branches     1341     1341              
==========================================
+ Hits         5594     5596       +2     
+ Misses        382      380       -2     

Impacted Files	Coverage Δ
packages/core/src/browser/pageExitObservable.ts	100.00% <ø> (ø)
packages/core/src/browser/runOnReadyState.ts	100.00% <ø> (ø)
...ges/core/src/domain/configuration/configuration.ts	92.50% <ø> (ø)
...s/core/src/domain/configuration/endpointBuilder.ts	100.00% <ø> (ø)
...kages/core/src/domain/console/consoleObservable.ts	100.00% <ø> (ø)
packages/core/src/domain/error/error.ts	92.59% <ø> (ø)
...ackages/core/src/domain/error/trackRuntimeError.ts	100.00% <ø> (ø)
.../domain/eventRateLimiter/createEventRateLimiter.ts	100.00% <ø> (ø)
...ackages/core/src/domain/report/reportObservable.ts	95.00% <ø> (ø)
...ages/core/src/domain/session/sessionCookieStore.ts	100.00% <ø> (ø)
... and 14 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[BenoitZugmeyer]

❓ question: ‏I'm wondering what made you move timer.ts in tools? For me, this module is similar to addEventListener.ts (provide safer or easier to use alternative to browser functions). Is it because setTimeout is more "JavaScript-y" and addEventListener is more DOM-oriented (thus "browser")?

[bcaudan]

Yes, it is what I tried to express with:

while it wraps a browser API, it is mainly used to control the execution flow

Components needing to react to window or document events would most likely be under domain or browser directories.
For timer APIs, any component needing to perform asynchronous operation could need them and we have usage from various areas of the code base.

The main driver is that it would avoid to have some tools components depending on code outside of tools.