🐛 [RUMF-1470] Sanitize - Fix size computation #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickadam
changed the title
packages/core/src/tools/sanitize.ts
Outdated
| accumulatedCharacterCount += JSON.stringify(targetData).length + separatorLength | ||
| // When an element of an Array (targetData) is undefined, it is serialized as null: | ||
| // JSON.stringify([undefined]) => '[null]' - This accounts for 4 characters | ||
| accumulatedCharacterCount += (JSON.stringify(targetData)?.length ?? 4) + separatorLength |
There was a problem hiding this comment.
💬 suggestion: Maybe it would be easier to understand with an if (targetData !== undefined) condition instead of relying on JSON.stringify(undefined) -> undefined
if (targetData === undefined) {
// When an element of an Array (targetData) is undefined, it is serialized as null:
// JSON.stringify([undefined]) => '[null]' - This accounts for 4 characters
accumulatedCharacterCount += 4
} else {
accumulatedCharacterCount += JSON.stringify(targetData).length
}
accumulatedCharacterCount += separatorLength
BenoitZugmeyer
approved these changes
Mar 31, 2023
bcaudan
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
sanitizegenerates telemetry errors (Exception TypeError)Changes
Proper computation of size for undefined values in objects and arrays
Testing
I have gone over the contributing documentation.