♻️[RUMF-1517] split domain utils

[bcaudan]

Motivation

Avoid single utils files

Changes

Remove record/utils and record/observers/utils by:

• moving getPathToNestedCSSRule to styleSheetObserver
• moving forEach and listenerObserver to core/tools/utils (for future specialisation)
• creating record/assembly (observer -> record assembly -> emit design could later evolve to match what we have for rum and logs events)
• creating eventsUtils
• creating recordIds

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[BenoitZugmeyer]

❓ question: ‏Why not keeping this a singleton?

[bcaudan]

Looking at it, it was not utility code but domain logic, so following the convention, I passed it as a dependency rather than statically import it.
By automatism, I switched the singleton getter to an object but indeed we could keep the singleton getter and pass it as a dependency.
Any pros/cons to favour the singleton?

[BenoitZugmeyer]

I'm a bit surprised to see this kind of change included in a PR focused on splitting files. I have mixed feelings on enforcing the "dependency as parameter" policy when it's not really needed, but fine.

Still, I think the getRecordIdForEvent name was clearer than recordIds.get. Maybe we could rename it recordIds.getIdForEvent?

[bcaudan]

Maybe we could rename it recordIds.getIdForEvent?

LGTM

I have mixed feelings on enforcing the "dependency as parameter" policy when it's not really needed, but fine.

We should chat about that to see if we can get aligned

[codecov-commenter]

Codecov Report

Merging #2105 (af37b16) into main (28d26bb) will decrease coverage by 0.12%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##             main    #2105      +/-   ##
==========================================
- Coverage   93.67%   93.55%   -0.12%     
==========================================
  Files         163      164       +1     
  Lines        5691     5694       +3     
  Branches     1303     1303              
==========================================
- Hits         5331     5327       -4     
- Misses        360      367       +7     

Impacted Files	Coverage Δ
packages/core/src/tools/utils.ts	81.56% <0.00%> (-0.65%)	⬇️
...s/rum/src/domain/record/observers/focusObserver.ts	100.00% <ø> (ø)
...s/rum/src/domain/record/observers/inputObserver.ts	79.06% <ø> (ø)
...omain/record/observers/mediaInteractionObserver.ts	27.27% <ø> (ø)
...es/rum/src/domain/record/observers/moveObserver.ts	95.65% <ø> (ø)
.../rum/src/domain/record/observers/scrollObserver.ts	25.00% <ø> (ø)
.../domain/record/observers/viewportResizeObserver.ts	78.57% <ø> (ø)
packages/rum/src/domain/record/record.ts	79.06% <ø> (ø)
packages/rum/src/domain/record/assembly.ts	100.00% <100.00%> (ø)
packages/rum/src/domain/record/eventsUtils.ts	100.00% <100.00%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more