Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Handle undefined cancel idle callback #2045

Merged
merged 1 commit into from
Mar 1, 2023
Merged

🐛 Handle undefined cancel idle callback #2045

merged 1 commit into from
Mar 1, 2023

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Feb 28, 2023 •
edited
Loading

Motivation

requestIdleCallback is not supported on Safari and some customer use polyfills that only polyfills requestIdleCallback but not cancelIdleCallback.

Changes

checks both requestIdleCallback and cancelIdleCallback existence

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner February 28, 2023 15:34
@amortemousque amortemousque merged commit 7c01c5f into main Mar 1, 2023
@amortemousque amortemousque deleted the aymeric/fix-cancelIdleCallback-not-function branch March 1, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

@bcaudan bcaudan bcaudan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amortemousque @BenoitZugmeyer @bcaudan