Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-1481] Remove product subdomain for ap1 intake requests #1997

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 6, 2023

Motivation

Avoid to setup specific subdomain for each product.

Changes

Remove product subdomain for ap1 intake requests.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner February 6, 2023 10:06
@codecov-commenter
Copy link

Codecov Report

Merging #1997 (cec03de) into main (a4d336c) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1997      +/-   ##
==========================================
+ Coverage   93.50%   93.60%   +0.09%     
==========================================
  Files         145      145              
  Lines        5515     5517       +2     
  Branches     1258     1259       +1     
==========================================
+ Hits         5157     5164       +7     
+ Misses        358      353       -5     
Impacted Files Coverage Δ
...s/core/src/domain/configuration/endpointBuilder.ts 100.00% <100.00%> (ø)
...kages/core/src/domain/configuration/intakeSites.ts 100.00% <100.00%> (ø)
...rum-core/src/domain/contexts/foregroundContexts.ts 98.46% <0.00%> (+7.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit de83531 into main Feb 6, 2023
@bcaudan bcaudan deleted the bcaudan/ap1-tweaks branch February 6, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants