Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1476] Fix removednodes.foreach is not a function #1984

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Jan 30, 2023

Motivation

Old browsers do not implement NodeList.prototype.forEach(). Add a check to isBrowserSupported

Changes

Add NodeList.prototype.forEach check to isBrowserSupported

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested review from a team as code owners January 30, 2023 10:30
@codecov-commenter
Copy link

Codecov Report

Merging #1984 (e18cf46) into main (1ab2229) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
- Coverage   93.38%   93.25%   -0.13%     
==========================================
  Files         144      144              
  Lines        5484     5484              
  Branches     1245     1245              
==========================================
- Hits         5121     5114       -7     
- Misses        363      370       +7     
Impacted Files Coverage Δ
packages/rum/src/boot/recorderApi.ts 96.15% <100.00%> (ø)
packages/rum/src/domain/record/mutationObserver.ts 96.50% <100.00%> (ø)
packages/rum/src/domain/record/serialize.ts 96.29% <100.00%> (ø)
packages/rum/src/domain/record/utils.ts 90.00% <0.00%> (-10.00%) ⬇️
...rum-core/src/domain/contexts/foregroundContexts.ts 90.76% <0.00%> (-6.16%) ⬇️
packages/core/src/tools/timeUtils.ts 97.43% <0.00%> (-2.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@amortemousque amortemousque merged commit 5ad73a0 into main Jan 30, 2023
@amortemousque amortemousque deleted the aymeric/fix-removednodes-foreach-issue branch January 30, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants