Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REPLAY] Add telemetry for shadow dom #1978

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

ThibautGeriz
Copy link
Contributor

@ThibautGeriz ThibautGeriz commented Jan 27, 2023

Motivation

[REPLAY] Add telemetry for shadow dom #1978

Changes

  • add shadow dom content if FF is present (only to be activated on org2 for privacy concerned)

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #1978 (206c60a) into main (0b3c063) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
+ Coverage   93.30%   93.32%   +0.02%     
==========================================
  Files         144      144              
  Lines        5479     5482       +3     
  Branches     1244     1247       +3     
==========================================
+ Hits         5112     5116       +4     
+ Misses        367      366       -1     
Impacted Files Coverage Δ
...ges/rum/src/domain/record/shadowRootsController.ts 60.00% <0.00%> (-6.67%) ⬇️
...rum-core/src/domain/contexts/foregroundContexts.ts 96.92% <0.00%> (+6.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ThibautGeriz ThibautGeriz marked this pull request as ready for review January 27, 2023 16:05
@ThibautGeriz ThibautGeriz requested review from a team as code owners January 27, 2023 16:05
@ThibautGeriz
Copy link
Contributor Author

/merge

@ThibautGeriz
Copy link
Contributor Author

/status

@temporal-github-worker-1
Copy link

🚂 MergeQueue Status

This merge request was enqueued 31m ago.

MergeQueue status for DataDog/browser-sdk branch main

There is currently no merge request being processed.

There is 1 merge request in the queue:

There is no merge request waiting

@ThibautGeriz
Copy link
Contributor Author

/donotmerge

@temporal-github-worker-1
Copy link

⚠️ MergeQueue

This merge request was unqueued

@ThibautGeriz ThibautGeriz merged commit f349b60 into main Jan 30, 2023
@ThibautGeriz ThibautGeriz deleted the thibaut.gery/add-telemetry-to-shadow-dom-2 branch January 30, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants