Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-1465] collect data for disturbed response #1977

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jan 27, 2023

Motivation

Following #1942, we still had some telemetry errors related to response.clone() in the case of disturbed response.

Changes

Add try/catch around response.clone() to prevent any thrown error to disturb our data collection.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner January 27, 2023 09:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #1977 (9767cfe) into main (98ee5d5) will increase coverage by 0.00%.
The diff coverage is 72.72%.

@@           Coverage Diff           @@
##             main    #1977   +/-   ##
=======================================
  Coverage   93.33%   93.34%           
=======================================
  Files         144      144           
  Lines        5477     5482    +5     
  Branches     1242     1243    +1     
=======================================
+ Hits         5112     5117    +5     
  Misses        365      365           
Impacted Files Coverage Δ
...sCollection/networkError/networkErrorCollection.ts 89.06% <40.00%> (+0.17%) ⬆️
packages/core/src/tools/utils.ts 82.21% <100.00%> (+0.28%) ⬆️
packages/rum-core/src/domain/requestCollection.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit 1c27a97 into main Jan 27, 2023
@bcaudan bcaudan deleted the bcaudan/clone-catch branch January 27, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants