⚗️✨ [RUMF-1379] heatmaps: enable descendant combined selectors #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we won't need multiple selectors anymore, rename the module to singular 'getSelectorFromElement'
bcaudan
approved these changes
Nov 8, 2022
BenoitZugmeyer
changed the title
liywjl
approved these changes
Nov 8, 2022
packages/rum-core/src/domain/rumEventsCollection/action/getSelectorFromElement.ts
Outdated
Show resolved
Hide resolved
When the element is the only one from its type within its siblings, the `getTagNameSelector` strategy used in UNIQUE_AMONG_CHILDREN_SELECTOR_GETTERS will succeed and `uniqueSelectorAmongChildren` will be defined. Thus,`getPositionSelector` will only be used when the tag name is not unique, so we don't need to check for tag name unicity again. This logic has been removed. Finally, we don't need to use `getTagNameSelector` once again, since `getPositionSelector` will always return a selector. This useless call has been removed.
|
👏 praise: Very good job on this whole topic! |
Codecov Report
@@ Coverage Diff @@
## main #1811 +/- ##
==========================================
+ Coverage 93.15% 93.22% +0.06%
==========================================
Files 130 130
Lines 5057 5049 -8
Branches 1131 1127 -4
==========================================
- Hits 4711 4707 -4
+ Misses 346 342 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
amortemousque
approved these changes
Nov 8, 2022
BenoitZugmeyer
deleted the
benoit/heatmap--enable-child-compound-selectors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After experimenting with #1741 , we chose to keep only one of the two experiments.
Changes
This PR promote the experimental selector as the default one, and does a bit of cleanup and redesign.
Testing
I have gone over the contributing documentation.