-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-1409] Provide setUser and related functions for logs SDK #1801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4b02f4c
to
959d08c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1801 +/- ##
==========================================
+ Coverage 93.15% 93.25% +0.09%
==========================================
Files 130 131 +1
Lines 5057 5067 +10
Branches 1131 1132 +1
==========================================
+ Hits 4711 4725 +14
+ Misses 346 342 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks, created DOCS-4334 to track as an editorial review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a wording suggestion that changes a sentence to active voice. Feel free to ignore it if it changes the meaning of the note.
f19d63f
to
7c66c5b
Compare
Motivation
Issue raised here: #1675
The RUM SDK provides convenient user-related functions. This change brings the same functions to the LOGS SDK.
Changes
Added the following functions to the logs public API:
setUser,
setUserProperty,
getUser,
removeUserProperty,
clearUser
Testing
I have gone over the contributing documentation.