Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[RUMF-1423] prevent unexpected behavior when our xhr are reused #1797

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Oct 27, 2022

Motivation

Following #1790, #1793, our new request strategy can be disturb if our xhr instances are reused to send other requests.

Changes

Prevent our xhr instances callback to be called multiple times.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner October 27, 2022 08:03
@codecov-commenter
Copy link

Codecov Report

Merging #1797 (1d83412) into main (43ebf59) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
+ Coverage   90.95%   90.98%   +0.03%     
==========================================
  Files         129      129              
  Lines        5042     5037       -5     
  Branches     1134     1132       -2     
==========================================
- Hits         4586     4583       -3     
+ Misses        456      454       -2     
Impacted Files Coverage Δ
...ckages/core/src/transport/sendWithRetryStrategy.ts 100.00% <ø> (+2.22%) ⬆️
packages/core/src/transport/httpRequest.ts 97.82% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DataDog DataDog deleted a comment from temporal-github-worker-1 bot Oct 27, 2022
@DataDog DataDog deleted a comment from temporal-github-worker-1 bot Oct 27, 2022
@bcaudan bcaudan merged commit a1aad12 into main Oct 27, 2022
@bcaudan bcaudan deleted the bcaudan/retry-telemetry-3 branch October 27, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants