Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-1356] selectors using stable attributes and no class names #1689

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Aug 11, 2022

Motivation

Explore various selector strategies for heatmaps. Don't use class names in CSS selector, as they might be unreliable in some cases.

Changes

Implement a new selector without class names.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/heatmap--selectors-without-classes branch from dda5bae to 0251c7c Compare August 11, 2022 14:31
@BenoitZugmeyer BenoitZugmeyer marked this pull request as ready for review August 11, 2022 14:32
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner August 11, 2022 14:32
@codecov-commenter
Copy link

Codecov Report

Merging #1689 (99b4697) into main (ec6b18e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
+ Coverage   90.47%   90.50%   +0.02%     
==========================================
  Files         128      128              
  Lines        4779     4779              
  Branches     1067     1067              
==========================================
+ Hits         4324     4325       +1     
+ Misses        455      454       -1     
Impacted Files Coverage Δ
...EventsCollection/action/getSelectorsFromElement.ts 100.00% <ø> (ø)
packages/core/src/tools/timeUtils.ts 100.00% <0.00%> (+2.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenoitZugmeyer BenoitZugmeyer merged commit b3c4a8c into main Aug 12, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/heatmap--selectors-without-classes branch August 12, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants