✨ [RUMF-1119] Implement dual ship for other orgs #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1248 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 104 104
Lines 4253 4254 +1
Branches 960 961 +1
=======================================
+ Hits 3791 3792 +1
Misses 462 462
Continue to review full report at Codecov.
|
bcaudan
reviewed
Jan 7, 2022
| @@ -35,7 +35,6 @@ export function defineGlobal<Global, Name extends keyof Global>(global: Global, | |||
|
|
|||
| export enum BuildMode { | |||
| RELEASE = 'release', | |||
| STAGING = 'staging', | |||
There was a problem hiding this comment.
❗ warning: it is still used in gitlab
Line 237 in ecf5255
bcaudan
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Other Datadog data sources are dual shipped to US1 (org 2). In order to allow correlation of this data with RUM data, we would like to dual ship browser data from other data centers (except govcloud) to US1.
The PR enable the replica configuration for other orgs
Changes
Add the new datacenter tag
Remove the browser SDK staging safe guard
Testing
I have gone over the contributing documentation.