Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse the config file before passing to create server #368

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

mintbridge
Copy link
Contributor

@mintbridge mintbridge commented Jul 25, 2016

at the moment running the server with uwsgi doesnt work as it passes the string path to the server instead of the config object, it fails with:

Traceback (most recent call last):
  File "/Documents/cubes/cubes/server/app.py", line 13, in <module>
    application = create_server(CONFIG_PATH)
  File "/Documents/cubes/cubes/server/base.py", line 38, in create_server
    if config.has_option("server", "modules"):
AttributeError: 'str' object has no attribute 'has_option'

this PR matches the behaviour of the slicer command https://github.com/DataBrewery/cubes/blob/master/cubes/slicer/commands.py#L59

@Stiivi Stiivi merged commit f3364d9 into DataBrewery:master Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants