Feature/extend batch support #285
Conversation
mccstan
changed the title
There was a problem hiding this comment.
Thank you for the contribution @mccstan !! A few points
- First and most importantly, thank you for the PR. We very much appreciate community support.
- Currently, the "source of truth" for dsub source code is in an internal repo. We won't be able to merge this PR directly. What we can do however is take it, add it to our internal system, and then acknowledge your contributions when it is shared back out to this repo.
- We are looking into ways to update our contribution acceptance policy so that we can directly merge PRs from the community.
- Could you please remove whitespace changes from this PR? I understand that several Python linters default to 4-space indents, but dsub's current linter uses 2. It may make sense to eventually adopt a 4-space indent, but when that happens we should make that change across all the files instead of just the few in this PR.
|
Thanks for reviewing @wnojopra Feel free to integrate and share when it is possible. I updated my linter to user 2 space style indent, but there is still some spaces remaining, I had to manually remove them. Thanks. |
|
Hi @mccstan! |
|
[image: Fichier PDF]
[externally shared] Verily Individual…
<https://drive.google.com/file/d/1N4RXOue_OLnG4jOGBZWDNtQAmP0dlr19/view?usp=drivesdk>
Le lun. 25 mars 2024 à 19:09, Willy Nojopranoto ***@***.***>
a écrit :
… Hi @mccstan <https://github.com/mccstan>!
We'd love to incorporate your work into dsub and improve our ability to
take in community contributions. We need to get our CONTRIBUTING doc
<https://github.com/DataBiosphere/dsub/blob/main/CONTRIBUTING.md>
updated, but in the meantime, can you please review and sign our Contributor
License Agreement
<https://docs.google.com/document/d/1Yc-z59DQKRqiqpVgHcIHC3xhfwm3DoPmpc9eFwr_J8c/edit?resourcekey=0-k9NMsHVrhlafbKiAIE9GoA&tab=t.0#heading=h.eqi47wqyyinr>?
You can send it to our IP team at ***@***.***
Thanks!
—
Reply to this email directly, view it on GitHub
<#285 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3ILBEWNSSDJGR75AZDX6DY2BR5TAVCNFSM6AAAAABELMKH3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGYYDKOBVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi, Is there a timeline on when these features might be added and officially released? Thanks! |
|
We've recently passed the IP contributors guidelines, and are now capable of accepting this PR into our internal repo. The next step is for me to run this through our tests and possibly add tests. Stay tuned, and thanks again to everyone for the interest and support. |
|
That's great news!
Le ven. 12 avr. 2024 à 01:55, Willy Nojopranoto ***@***.***>
a écrit :
… We've recently passed the IP contributors guidelines, and are now capable
of accepting this PR into our internal repo. The next step is for me to run
this through our tests and possibly add tests. Stay tuned, and thanks again
to everyone for the interest and support.
—
Reply to this email directly, view it on GitHub
<#285 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3ILBAIVTMPGR533RIM7ETY44PI5AVCNFSM6AAAAABELMKH3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQG4ZTIMBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Just a quick update on this - we have this PR working internally with tests. A release with this update is coming soon. |
|
Closing this PR as this has now been included with the latest release Once again, thank you for the PR. We very much appreciate community support. |
Fix ignored configs when submitting jobs against Google Batch :
Doing :