Support ruby 3 #249
Closed
Support ruby 3 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did the tests passed successfully after those changes? |
Closed
|
Could this PR get merged? |
|
Soon, I hope. I've got a really annoying set of interacting test failures across different ruby versions, and it's being a right pain to solve. Sorry :( |
sdt
pushed a commit
to sdt/csvlint.rb
that referenced
this pull request
Jun 20, 2022
Cherry-picked (by hand) from Data-Liberation-Front#249
sdt
pushed a commit
to sdt/csvlint.rb
that referenced
this pull request
Jun 20, 2022
Cherry-picked (by hand) from Data-Liberation-Front#249
|
After a lot of wrangling, Ruby 3 support is finally merged in under #264. Thanks for your work here, it helped me get it all straightened out, even though I didn't merge this PR directly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ruby 3