Fix blinking cues when segmented over multiple segments or chunks (cont'd) #4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsecutive segments or chunks
…onsecutive segments or chunks
…onsecutive segments or chunks
…isable patching of segmented cues
- resolve images urls in isd returned by imsc-1 lib before analysing and pushing the cues - compare isd and not images and embeddedImages fields from TTML (since different images ids/references can refer to same image content)
- fix regression for embedded cues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is following PR #4103 in order to fix blinking cues in case of chunked images subtitles.
In order to compare contiguous cues, image sources are now resolved before comparing cues content (= isd returned by IMSC-1 library parser), instead of being resolved only while rendering the cues.
This allows to compare all images contents and to handle comparing images with different ids or references but with the same content.
An issue has also been reported in IMSC-1 to ask for image sources to be resolved while generating the isd contents (see sandflow/imscJS#241).
This PR also provides some additionnal minor fixes: