Restart ScheduleController once buffer is pruned only after QuotaExceedeError #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ScheduleController there is a mechanism to restart the scheduler once buffer has been pruned in case of QuotaExceededError.
But scheduler may have been stopped for some other reasons/errors, for example if BaseURL resolution failed (after a segment download error for example).
And since there is a buffer pruning timer (every 10sec by default, see bufferPruningInterval parameter) then the scheduler was also restarted in this case, which is not the desired behavior.
We want the scheduler to restart automatically only after QuotaExceedeError.
This PR fixes this issue.