fix: use fallback ID if Name is undefined

[eowino]

Description

This PR addresses the issue described here: #3187

[eowino]

@dsilhavy Please review. I'll send over the feedback agreement soon.

[dsilhavy]

@eowino Thanks for this PR. Following our contribution guidelines, and given this is your first PR, could you please send to me a signed copy of dash.js feedback agreement?

Thanks!

[eowino]

@eowino Thanks for this PR. Following our contribution guidelines, and given this is your first PR, could you please send to me a signed copy of dash.js feedback agreement?

Thanks!

@dsilhavy I have now emailed you a signed copy of dash.js feedback agreement.

[bbert]

I propose you a more compact way of doing it, by replacing lines 120 to 123 by the following ones:

const name = streamIndex.getAttribute('Name');
const type = streamIndex.getAttribute('Type');
const lang = streamIndex.getAttribute('Language');
adaptationSet.id = name || (type + '_' + lang);
adaptationSet.contentType = type;
adaptationSet.lang = lang || 'und';
adaptationSet.mimeType = mimeTypeMap[type];

If you agree with that, please commit and push, and then I'll do merge

[eowino]

@bbert

// I went with this
const fallBackId = lang ? type + '_' + lang : type;
adaptationSet.id = name || fallBackId;

// rather than this as lang is optional
adaptationSet.id = name || (type + '_' + lang);

[bbert]

Yes I saw, good point!
My reasoning is that if name was not provided, then lang was obviously provided.
But that works fine this way.
Thanks!