Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring code #3166

Closed
wants to merge 24 commits into from
Closed

Refactoring code #3166

wants to merge 24 commits into from

Conversation

nicosang
Copy link
Contributor

Hi,

this PR has to refactor the code source :

  • remove unused code
  • reduce mutual dependance (for instance : scheduleController and streamProcessor)
  • remove NextFragmentRequestRule, use event instead

Nico

@dsilhavy dsilhavy added this to the 3.1.0 milestone Jan 16, 2020
@dsilhavy dsilhavy modified the milestones: 3.1.0, 3.1.1 Feb 6, 2020
@bbert bbert force-pushed the removeDoubleDependency branch from ad41932 to c1e4378 Compare March 17, 2020 14:25
@bbert bbert force-pushed the removeDoubleDependency branch from 3dd13a8 to 37391c5 Compare March 20, 2020 08:18
nicosang and others added 22 commits March 25, 2020 14:26
@nicosang @bbert
remove unused reference
7bc1f96
@nicosang @bbert
when an init data is needed, scheduleController has to send an event …
43ba44e 
…that will be catched by streamProcessor to request init segment.

First step to remove dependence between scheduleController and streamProcessor
@nicosang @bbert
reduce streamProcessors reference in ScheduleController
f089bf5
@nicosang @bbert
setLiveEdgeSeekTarget has been moved in StreamProcessor class
fb1603e
@nicosang @bbert
INIT_FRAGMENT_LOADED and MEDIA_FRAGMENT_LOADED events don't need to u…
fc22f8a 
…se a reference to fragmentModel : chunk has stream id and media stream type
@nicosang @bbert
reduce references to streamProcessor
855b030
@nicosang @bbert
when an init data is needed, scheduleController has to send an event …
8d33454 
…that will be catched by streamProcessor to request init segment.

First step to remove dependence between scheduleController and streamProcessor
@nicosang @bbert
reduce streamProcessors reference in ScheduleController
76feb32
@nicosang @bbert
setLiveEdgeSeekTarget has been moved in StreamProcessor class
dc809d7
@nicosang @bbert
reduce references to streamProcessor
543e43f
@nicosang @bbert
update STREAM_COMPLETED event
48d619a
@nicosang @bbert
request element was missing in INIT_FRAGMENT_LOADED
2966f9d
@nicosang @bbert
reduce streamProcessor reference
d567d28
@bbert
add removeExecutedRequestsBeforeTime function in StreamProcessor class
a755c5a
@nicosang @bbert
remove getFragmentController function
da92a22
@nicosang @bbert
add removeExecutedRequestsAfterTime and abortRequests functions to St…
bfefdfe 
…reamProcessor class
@nicosang @bbert
add getRequests function to StreamProcessor
d831da2
@nicosang @bbert
add NEW_FRAGMENT_NEEDED event, remove NextFragmentRequestRule
49b6088
@nicosang @bbert
reduce streamProcessor references in BufferController, add ADD_INBAND…
40704c4 
…_EVENTS_REQUESTED event
@nicosang @bbert
update tests in OnMediaFragmentLoaded callback
be9526a
@bbert
add isMediaSegmentRequest function
7ae827c
@bbert
fix after rebase
7ebde64
@bbert bbert force-pushed the removeDoubleDependency branch from 37391c5 to 7ebde64 Compare March 25, 2020 13:30
@dsilhavy dsilhavy removed this from the 3.1.0 milestone Mar 26, 2020
@bbert bbert mentioned this pull request Mar 27, 2020
Merged
@bbert
Copy link
Contributor

bbert commented Jun 4, 2020

replaced by PR #3256

@bbert bbert closed this Jun 4, 2020
@bbert bbert deleted the removeDoubleDependency branch June 4, 2020 06:46
@nicosang
Copy link
Contributor Author

nicosang commented Jun 4, 2020

thanks @bbert ! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Refactor Work in Progress - Don't Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicosang @bbert @dsilhavy