Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Avoid jumps in the livestream when an incorrect currentTime is reported by video element #3159

Merged
merged 2 commits into from
Jan 14, 2020
Merged

[Fix] Avoid jumps in the livestream when an incorrect currentTime is reported by video element #3159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ffdf5e
[Fix] Avoid jumps in the livestream when an incorrect currentTime is …
Jan 14, 2020
e305e34
Merge branch 'development' into bugfix-livestreamjump
dsilhavy Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/streaming/controllers/PlaybackController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,10 +400,14 @@ function PlaybackController() {
const DVRWindow = DVRMetrics ? DVRMetrics.range : null;
let actualTime;

if (!DVRWindow) return NaN;
if (!DVRWindow) {
return NaN;
}
if (currentTime > DVRWindow.end) {
actualTime = Math.max(DVRWindow.end - streamInfo.manifestInfo.minBufferTime * 2, DVRWindow.start);
} else if (currentTime > 0 && currentTime + 0.250 < DVRWindow.start && DVRWindow.start - currentTime > DVRWindow.start - 315360000) {

} else if (currentTime > 0 && currentTime + 0.250 < DVRWindow.start && Math.abs(currentTime - DVRWindow.start) < 315360000) {

// Checking currentTime plus 250ms as the 'timeupdate' is fired with a frequency between 4Hz and 66Hz
// https://developer.mozilla.org/en-US/docs/Web/Events/timeupdate
// http://w3c.github.io/html/single-page.html#offsets-into-the-media-resource
Expand Down