SegmentBase Multi period bug fix #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal seek is done, this attribute was never reset..
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to resolve issue #2840 by reseting seekStartTime value in all cases when the stream begins to play. In this specific use case (SegmentBase multi period), no internal seek is done to start, for instance, the second period. The seekStartTime value is still 30.03s. the getWorkingTime function always returns 30.03s. BufferLevelRule doesn't have correct informations to decide or not to request new segment.
@niralipatelgoogle, I know this issue is open for a long time, but it would be great if you can take a look at this fix. Thank you!
Nico