Fix starting of live streams with SegmentTimeline #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if live stream not yet started (currentTime = 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For live streams with SegmentTimeline thus manifest refreshes, when manifest is updated, the player checks if current playback time is not anterior to DVR window start, and then it seeks to DVR window start (I guess to ensure to download and play available segments)
However, when loading the stream, if manifest is first updated before live is started (currentTime still equal to 0) then a seek to DVR window start is performed.
This PR fixes this issue by ignoring DVR window resynchronization if stream is not started yet.