Reduce dependencies #3086
Merged
Reduce dependencies #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiclabsDASH
reviewed
Oct 7, 2019
…in ScheduleController remove dependance to streamProcessor in liveEdgeFinder
RepresentationController is created in StreamProcessor, but the instance of StreamProcessor is not an attribute of RepresentationController
nicosang
force-pushed
the
reduceDependencies
branch
from
11c8e62 to
1d5d068
Compare
epiclabsDASH
reviewed
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a new refactoring PR. The main goals achieved by this PR are :
remove reference of StreamProcessor in DashHandler
remove reference of StreamProcessor in RepresentationController
Both objects, DashHandler and RepresentationController, are created by StreamProcessor. Those elements don't have to keep a reference on the object in which they have been created.
Nico