Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Bug fix #2971

Conversation

nicosang
Copy link
Contributor

Hi,

this PR has to solve regression #2966 introduced by myself in PR #2881. This previous PR aimed to remove dependancy between dashAdapter and MediaController. The problem is that the first selected track is not set by function setCurrentMediaInfo because processors are not created at this specific time.

There is still an issue after this new PR that refer to issue #2970.... :-(

@sgadrat-anevia, could you, please, take a look at this PR?

Thanks,
Nico

@sgadrat-anevia
Copy link

I confirm that it fixes #2966. With your proposed patch the stream plays.

Playout is jerky, while smooth in 2.9.2 (if we manually select an audio quality before the error). Anyway, it seems to be the issue described by #2970

Thank you

@epiclabsDASH
Copy link
Contributor

#2970 is related with an issue in ControlBar that team here is fixing so let's work in it in parallel. Thanks!

@epiclabsDASH epiclabsDASH added this to the v3.0 milestone Apr 16, 2019
@epiclabsDASH epiclabsDASH merged commit 65ddb6a into Dash-Industry-Forum:development Apr 16, 2019
@nicosang nicosang deleted the audioSwitchBugFix branch April 23, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants