A fix for issue #2877 #2879
A fix for issue #2877 #2879
Conversation
…ctly handle multiple simultaneous events with identical "value"s, fixing issue Dash-Industry-Forum#2877.
|
Hi @JoeEylesBBC , thanks for your PR. Could you, please, update the unit test in order to be able to merge it? Thanks again, |
|
@JoeEylesBBC, given this is your first contribution and following dash.js contribution guidelines, could you please also send the feedback agreement document signed by you? |
|
Hi all, Sorry for the late reply. It seems you should already have a signed CLA from the BBC R&D department - see https://github.com/Dash-Industry-Forum/dash.js/wiki/Meeting-Minutes#minutes-april-4th-2014 Joe |
…e to the events being checked by a setInterval every 0.1s, at which point the last 0.1s of events would be triggered; but the setInterval would sometimes call after more than 0.1s, and thus any events older than 0.1s would not be triggered.
|
Hi all, I have just fixed a bug in which some events were not getting called and added it to this PR. This was due to the events being checked by a setInterval() every 0.1s, at which point the last 0.1s of events would be triggered; but the setInterval() would sometimes call after more than 0.1s, and thus any events older than 0.1s would not be triggered. |
Changed the string used to identify incoming
eventStreamsin order to correctly handle multiple simultaneous events with differentvalues. fixing issue #2877.