Errors type script + JSDoc comments #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build/typings/index.d.ts
Outdated
|
|
||
| interface MediaPlayerErrors { | ||
| MANIFEST_LOADER_PARSING_FAILURE_ERROR_CODE: 10; | ||
| MANIFEST_LOADER_LOADING_FAILURE_ERROR_CODE: 12; |
There was a problem hiding this comment.
Need to update numbers here, right?
There was a problem hiding this comment.
a rebase has been done, it should be ok now.
nicosang
force-pushed
the
addErrorsTypeScript
branch
from
236abae to
9247e48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to update typeScript definition with errors definition. Some comments about errors have been added in order to generate JSDoc.
Nico