getSegmentForTime is returning indicies off by one segment (#3122)

* Fix for getSegementForTime requesting the segment before * Fix the test that got segment indexes wrong
Dash-Industry-Forum · Nov 27, 2019 · fde839c · fde839c
1 parent 7608668
commit fde839c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/dash/utils/TemplateSegmentsGetter.js b/src/dash/utils/TemplateSegmentsGetter.js
@@ -94,7 +94,7 @@ function TemplateSegmentsGetter(config, isDynamic) {
         }
 
         const periodTime = timelineConverter.calcPeriodRelativeTimeFromMpdRelativeTime(representation, requestedTime);
-        const index = Math.floor(periodTime / duration) - 1;
+        const index = Math.floor(periodTime / duration);
 
         return getSegmentByIndex(representation, index);
     }

diff --git a/test/unit/dash.utils.TemplateSegmentsGetter.js b/test/unit/dash.utils.TemplateSegmentsGetter.js
@@ -117,13 +117,13 @@ describe('TemplateSegmentsGetter', () => {
             expect(seg.duration).to.equal(5);
 
             seg = templateSegmentsGetter.getSegmentByTime(representation, 12);
-            expect(seg.availabilityIdx).to.equal(1);
-            expect(seg.presentationStartTime).to.equal(5);
+            expect(seg.availabilityIdx).to.equal(2);
+            expect(seg.presentationStartTime).to.equal(10);
             expect(seg.duration).to.equal(5);
 
             seg = templateSegmentsGetter.getSegmentByTime(representation, 17);
-            expect(seg.availabilityIdx).to.equal(2);
-            expect(seg.presentationStartTime).to.equal(10);
+            expect(seg.availabilityIdx).to.equal(3);
+            expect(seg.presentationStartTime).to.equal(15);
             expect(seg.duration).to.equal(5);
         });