Dispatch volumechange from the native video element via dedicated Med…

…iaPlayerEvent (#3969)
Dash-Industry-Forum · Jun 27, 2022 · d7cc9b8 · d7cc9b8
1 parent 3d870ed
commit d7cc9b8
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -747,6 +747,7 @@ declare namespace dashjs {
         PLAYBACK_STALLED: 'playbackStalled';
         PLAYBACK_STARTED: 'playbackStarted';
         PLAYBACK_TIME_UPDATED: 'playbackTimeUpdated';
+        PLAYBACK_VOLUME_CHANGED: 'playbackVolumeChanged';
         PLAYBACK_WAITING: 'playbackWaiting';
         PROTECTION_CREATED: 'public_protectioncreated';
         PROTECTION_DESTROYED: 'public_protectiondestroyed';

diff --git a/src/streaming/MediaPlayerEvents.js b/src/streaming/MediaPlayerEvents.js
@@ -354,6 +354,12 @@ class MediaPlayerEvents extends EventsBase {
          */
         this.PLAYBACK_TIME_UPDATED = 'playbackTimeUpdated';
 
+        /**
+         * Sent when the video element reports that the volume has changed
+         * @event MediaPlayerEvents#PLAYBACK_VOLUME_CHANGED
+         */
+        this.PLAYBACK_VOLUME_CHANGED = 'playbackVolumeChanged';
+
         /**
          * Sent when the media playback has stopped because of a temporary lack of data.
          *

diff --git a/src/streaming/controllers/PlaybackController.js b/src/streaming/controllers/PlaybackController.js
@@ -614,6 +614,10 @@ function PlaybackController() {
         eventBus.trigger(Events.PLAYBACK_ENDED, { 'isLast': streamInfo.isLast });
     }
 
+    function _onVolumeChanged() {
+        eventBus.trigger(Events.PLAYBACK_VOLUME_CHANGED);
+    }
+
     // Handle DASH PLAYBACK_ENDED event
     function _onPlaybackEnded(e) {
         if (wallclockTimeIntervalId && e.isLast) {
@@ -771,6 +775,7 @@ function PlaybackController() {
         videoModel.addEventListener('loadeddata', _onPlaybackLoadedData);
         videoModel.addEventListener('stalled', onPlaybackStalled);
         videoModel.addEventListener('ended', _onNativePlaybackEnded);
+        videoModel.addEventListener('volumechange', _onVolumeChanged);
     }
 
     function removeAllListeners() {
@@ -790,6 +795,7 @@ function PlaybackController() {
         videoModel.removeEventListener('loadeddata', _onPlaybackLoadedData);
         videoModel.removeEventListener('stalled', onPlaybackStalled);
         videoModel.removeEventListener('ended', _onNativePlaybackEnded);
+        videoModel.removeEventListener('volumechange', _onVolumeChanged);
     }
 
     instance = {