Skip to content

Commit

Permalink
get AudioChannelConfiguration from representation, not only from adap…
Browse files Browse the repository at this point in the history
…tation (#3044)
  • Loading branch information
nicosang authored and epiclabsDASH committed Aug 16, 2019
1 parent f4280aa commit 2348495
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/dash/DashAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,12 @@ function DashAdapter() {
mediaInfo.audioChannelConfiguration = dashManifestModel.getAudioChannelConfigurationForAdaptation(realAdaptation).map(function (audioChannelConfiguration) {
return audioChannelConfiguration.value;
});

if (mediaInfo.audioChannelConfiguration.length === 0 && Array.isArray(realAdaptation.Representation_asArray) && realAdaptation.Representation_asArray.length > 0 ) {
mediaInfo.audioChannelConfiguration = dashManifestModel.getAudioChannelConfigurationForRepresentation(realAdaptation.Representation_asArray[0]).map(function (audioChannelConfiguration) {
return audioChannelConfiguration.value;
});
}
mediaInfo.roles = dashManifestModel.getRolesForAdaptation(realAdaptation).map(function (role) {
return role.value;
});
Expand Down
5 changes: 5 additions & 0 deletions src/dash/models/DashManifestModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ function DashManifestModel() {
return adaptation && adaptation.hasOwnProperty(DashConstants.AUDIOCHANNELCONFIGURATION_ASARRAY) ? adaptation.AudioChannelConfiguration_asArray : [];
}

function getAudioChannelConfigurationForRepresentation(representation) {
return representation && representation.hasOwnProperty(DashConstants.AUDIOCHANNELCONFIGURATION_ASARRAY) ? representation.AudioChannelConfiguration_asArray : [];
}

function getRepresentationSortFunction() {
return (a, b) => a.bandwidth - b.bandwidth;
}
Expand Down Expand Up @@ -1054,6 +1058,7 @@ function DashManifestModel() {
getRolesForAdaptation: getRolesForAdaptation,
getAccessibilityForAdaptation: getAccessibilityForAdaptation,
getAudioChannelConfigurationForAdaptation: getAudioChannelConfigurationForAdaptation,
getAudioChannelConfigurationForRepresentation: getAudioChannelConfigurationForRepresentation,
getAdaptationForIndex: getAdaptationForIndex,
getIndexForAdaptation: getIndexForAdaptation,
getAdaptationForId: getAdaptationForId,
Expand Down

0 comments on commit 2348495

Please sign in to comment.