Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose README and docker-entrypoint updates #179

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Docker compose README and docker-entrypoint updates #179

merged 3 commits into from
Oct 14, 2024

Conversation

ChiffX
Copy link
Contributor

@ChiffX ChiffX commented Oct 14, 2024

Changes:

  1. Command character is now passed to the container when set as an environment variable
  2. README updated with docker compose instructions

Changes were tested on a local build of the image: https://hub.docker.com/r/chiffx/discordsoundboard
The latest official dockerhub image could likely use a bump for some of the recent Java changes.

Darkside138
Darkside138 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Owner

@Darkside138 Darkside138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@Darkside138 Darkside138 merged commit 5a30cf4 into Darkside138:master Oct 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkside138 Darkside138 Darkside138 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiffX @Darkside138