Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text highlighting in Google Book Preview #166

Closed
Dansoftowner opened this issue May 2, 2022 · 0 comments
Closed

Allow text highlighting in Google Book Preview #166

Dansoftowner opened this issue May 2, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Dansoftowner
Copy link
Owner

In the Google Book Details panel it's impossible to highlight/select the description-text.
That's because currently the rendering is done by a MarkdownView (and because of that the HTML description needs be converted into markdown at the first step -> bad performance).

Suggestion:
Use a WebView to render the content. That's now possible because in JavaFX 18 it's possible to make it's background transparent.

Benefits:

  • Improved performance (no need to convert html to markdown), can get rid of the jHtml2Md dependency
  • The WebView allows to highlight selected text

Drawback(s):

  • It will be harder to make the web-content synchronous with the Theme
    • Solution:
      • The WebEngine allows to set a user-stylesheet (containing web-css)
      • The Theme class should provide a web-view stylesheet (e.g by a getSimpleWebViewStylesheet(): String)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant