Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt the user to rename the item when creating a currency (if the item already has a display name) #176

Closed
renbinden opened this issue Nov 18, 2022 · 3 comments
Labels
improvement New feature or request
Milestone

Comments

@renbinden
Copy link
Member

Users who are used to Currencies 1 like that the item would automatically name to the currency name. We should prompt users to rename the item when creating a currency before it is created, allowing users the choice between the existing name of the item or another name.

@dmccoystephenson
Copy link
Member

Rather than prompt the user, it would be simpler to automatically name the item to the currency name. I'd like to go for that for now and move this to the v2.1.0 milestone.

I've created #180 for this.

@renbinden
Copy link
Member Author

renbinden commented Dec 6, 2022

Rather than prompt the user, it would be simpler to automatically name the item to the currency name. I'd like to go for that for now and move this to the v2.1.0 milestone.

I've created #180 for this.

I think this is simple enough - when creating a currency, a conversation can be used with a BooleanPrompt. Another option would be to use clickable buttons using text components with a click action that specifies an additional command parameter.
We could potentially only show it when the item has a display name, and default to renaming all items with no display name.

@dmccoystephenson
Copy link
Member

Showing the prompt when the item has a set display name sounds good to me! I haven't worked with conversations yet, so that'll be a learning experience for me.

@dmccoystephenson dmccoystephenson changed the title Prompt the user to rename the item when creating a currency Prompt the user to rename the item when creating a currency (if the item already has a display name) Dec 6, 2022
@dmccoystephenson dmccoystephenson modified the milestones: v2.1.0, v2.0.0 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants