Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax check #148

Merged
merged 14 commits into from
Feb 10, 2025
Merged

Syntax check #148

merged 14 commits into from
Feb 10, 2025

Conversation

evannawfal
Copy link
Collaborator

@evannawfal evannawfal commented Feb 7, 2025

Syntax checker + running tests before PR can be reviewed & before pushing to main branch.

Also fixed a few failing tests + bugfix for toggleParticipation in EventService

@evannawfal evannawfal requested a review from Daggerpov February 8, 2025 01:34
@@ -647,24 +647,6 @@ void inviteUser_ShouldReturnTrue_WhenUserAlreadyInvited() {
verify(eventUserRepository, never()).save(any(EventUser.class));
}

@Test
void toggleParticipation_ShouldToggleStatus_WhenUserIsInvitedOrParticipating() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we fix this test instead of removing it?

Copy link
Owner

@Daggerpov Daggerpov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to approve once we fix the deleted test case

@evannawfal evannawfal requested a review from Daggerpov February 10, 2025 02:27
Copy link
Owner

@Daggerpov Daggerpov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@Daggerpov Daggerpov merged commit 5ca4784 into main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants