Skip partition labels

[cotedm]

Skip partition label group by per #31

[Zohimi]

indentation seems off.

[Dabz]

Got the same feeling, go fmt seems right, but: @cotedm used spaces instead of tab.
Debating about space vs tabs is not really productive, but I will change those to tabs in order to be consistent with the rest of the files.

[Dabz]

indentation: fixed

[cotedm]

whoops sorry about the format mismatch!

[Dabz]

I tested locally, it seems to have no impact (one day - I will have automatic testing ^^). Let me merge and it should trigger the docker build automatically

[Dabz]

Actually, I noticed that we still return the partition label to Prometheus:
ccloud_metric_received_bytes{cluster_id="lkc-ldrq7",partition="<nil>",topic="_confluent-controlcenter-5-5-0-1-KSTREAM-OUTEROTHER-0000000105-store-changelog"}
I will still merge it, in a later release I will ensure that this label is not pushed to Prometheus.

[sirianni]

Late to the party here, but would it be safer to have a whitelist of labels that we include rather than a blacklist (partition being on the "blacklist"). This was the original implementation that @Dabz had prior to this change

Ideally this would be configurable. This is how the cloudwatch exporter works (see aws_dimension config).

[Dabz]

Completely agree with you @sirianni , I merged it as a "quick win" but I am planning to do some refactoring in the near future (aka, once I got a free day). I opened #31 and #32 to trace my plans (and mostly not to forget them 😅 ). The goal is:

• Having a whitelist of labels we want to group by and avoid any hardcoded value in the functions itself
• Do not push all labels to Prometheus, but only the one we are grouping by (otherwise we got null values)
• Having a configurable whitelist of metrics we want to expose (either through a CLI or configuration file)