Memcpy issues

[ahezard]

The usage of memcpy in cardengine_arm9 to copy data from the cache to the card_read destination can create corruption of the memory in some specific cases :
// Copy directly
memcpy(dst, (u8*)buffer+(src-sector), len2);
The usage of readCached (only used for few roms) should solves this but in some cases it seems that it does not.

[ahezard]

Example of issue created by memcpy and solved by adding readCached reference : #261

[ahezard]

Another related issue that may be present in some games : the icache may need to be invalidated even if the data is moved by CPU.
The code is manipulated as data by the CPU and not as instruction when moved from the rom to the memory so if the dst region is in the instruction cache already it creates an issue.
The dst region should be dflushed and then iinvalidated.

[ahezard]

http://www.coranac.com/2008/01/tonccpy/

[ahezard]

fixed by using tonccpy

[ahezard]

On DSi, some pixels are missing on the Lan/Megaman sprite in the opening of MMBN5.
as well as the title screen of Anno 1701.
With tonccpy

[ahezard]

Could be linked to the cardReadNormal code