Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update camstats PvlGroup "User Parameters" to UserParameters #5672

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

AustinSanders
Copy link
Contributor

Description

Updated camstats PvlGroup "User Parameters" to UserParameters for PVL compliance.

Related Issue

Closes #5625

How Has This Been Validated?

Running camstats produces PVL with the following segment:

Group = UserParameters
  Filename = out.cub
  Linc     = 1
  Sinc     = 1
End_Group

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5672".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, this can go into dev but is technically API breaking. It should be released alongside 9.0 but not in any 8.Y.Z version

@AustinSanders AustinSanders merged commit 32120b8 into DOI-USGS:dev Nov 18, 2024
2 checks passed
@github-actions github-actions bot added the bug Something isn't working label Nov 18, 2024
chkim-usgs pushed a commit to chkim-usgs/ISIS3 that referenced this pull request Nov 26, 2024
…S#5672)

* Updated 'User Parameters' group to UserParameters for PVL compliance

* Updated changelog
chkim-usgs pushed a commit to chkim-usgs/ISIS3 that referenced this pull request Nov 26, 2024
…S#5672)

* Updated 'User Parameters' group to UserParameters for PVL compliance

* Updated changelog
@chkim-usgs chkim-usgs added the breaking API breaking change label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking API breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CamStats Output is not valid PVL - Parsing issues
3 participants