Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QView Stretch tool min/max type selection feature #5455

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

chkim-usgs
Copy link
Contributor

@chkim-usgs chkim-usgs commented Apr 4, 2024

Description

The related issue linked below explains how the min/max values in the QView Stretch tool does not show the entire dynamic range of the min/max values in comparison to the stats output. The stats app outputs the absolute min/max values while the Stretch tool uses the best min/max values which is the better value of either the absolute or Chebyshev values. This could lead to confusion as to why there are two min/max types showing and may require a second tool to confirm the min/max values as OP states.

This added feature gives the user the option to set the min/max types given three presets (Best, Absolute, & Chebyshev) from which the stretch view will change accordingly. The user still has the freedom to input their own min/max values in the text box and change other params as they choose.

Also added a "What's This" note as well, so if you open the Stretch Tool within QView then select the "What's This" feature (cursor with question mark icon), you can then select the drop-down (default "Best") and there is more info regarding this feature.

Related Issue

Addresses #5289

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Contributor

@AustinSanders AustinSanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should be mergeable pending tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants