Changes for 8.1.0_RC2 #5387
Merged
Changes for 8.1.0_RC2 #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
reviewed
Dec 21, 2023
| @@ -1,5 +1,5 @@ | |||
| mkdir build | |||
| cd build | |||
| export ISISROOT=$PWD | |||
| cmake -GNinja -DJP2KFLAG=ON -Dpybindings=OFF -DKAKADU_INCLUDE_DIR=/isisData/kakadu -DbuildTests=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$PREFIX ../isis | |||
There was a problem hiding this comment.
We probably should leave the Kakadu include dir. I imagine it was from local testing?
There was a problem hiding this comment.
Hm I think there was a mix up during rebasing my 8.1 branch off of the official 8.1 branch but got this reverted, good catch.
Kelvinrr
previously approved these changes
Dec 22, 2023
There was a problem hiding this comment.
I think we can undraft this. But we should also include this into the main repo. I think the "cleaner" way would be merge into the main repo then cherry-pick into the 8.1 branch. But I'll leave it up to you how to do it since how small the change is, it's kind of whatever.
12 tasks
chkim-usgs
added a commit
to chkim-usgs/ISIS3
that referenced
this pull request
Jan 8, 2024
* Fix dependency formatting in meta.yaml * Pin gsl, update docs * Revert pin * Pin gsl to 2.6 * Add 8.1.0_RC1 as separate code entry * Update the urls for 8.0 entry * Turn on python bindings to be installed during build * Add back kakadu build
chkim-usgs
added a commit
to chkim-usgs/ISIS3
that referenced
this pull request
Jan 8, 2024
This reverts commit 7994454.
chkim-usgs
added a commit
that referenced
this pull request
Jan 10, 2024
* 8.2.0_RC2 updates * Changes for 8.1.0_RC2 (#5387) * Fix dependency formatting in meta.yaml * Pin gsl, update docs * Revert pin * Pin gsl to 2.6 * Add 8.1.0_RC1 as separate code entry * Update the urls for 8.0 entry * Turn on python bindings to be installed during build * Add back kakadu build * Add pybindings changelog entry * Revert "Changes for 8.1.0_RC2 (#5387)" This reverts commit 7994454. * Bump ALE to 0.10.0 * Update csm plugins path from CONDA_PREFIX to ISISROOT
chkim-usgs
added a commit
that referenced
this pull request
Jan 10, 2024
* 8.2.0_RC2 updates * Changes for 8.1.0_RC2 (#5387) * Fix dependency formatting in meta.yaml * Pin gsl, update docs * Revert pin * Pin gsl to 2.6 * Add 8.1.0_RC1 as separate code entry * Update the urls for 8.0 entry * Turn on python bindings to be installed during build * Add back kakadu build * Add pybindings changelog entry * Revert "Changes for 8.1.0_RC2 (#5387)" This reverts commit 7994454. * Bump ALE to 0.10.0 * Update csm plugins path from CONDA_PREFIX to ISISROOT
chkim-usgs
added a commit
that referenced
this pull request
Jan 10, 2024
* Update csm plugins path in IsisPreferences (#5397) * Update csm plugins path in IsisPreferences * Update changelog * Add trailing slash * 8.1.0_RC2 version ticks * Moved changelog entry * 8.1.0_RC2 Updates (#5399) * 8.2.0_RC2 updates * Changes for 8.1.0_RC2 (#5387) * Fix dependency formatting in meta.yaml * Pin gsl, update docs * Revert pin * Pin gsl to 2.6 * Add 8.1.0_RC1 as separate code entry * Update the urls for 8.0 entry * Turn on python bindings to be installed during build * Add back kakadu build * Add pybindings changelog entry * Revert "Changes for 8.1.0_RC2 (#5387)" This reverts commit 7994454. * Bump ALE to 0.10.0 * Update csm plugins path from CONDA_PREFIX to ISISROOT * Set build num to 0, add back rc1 code entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes fixes and other changes for upcoming 8.1.0 Release Candidate 2:
Related Issue
How Has This Been Validated?
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: