Added --no-kernels flag to downoadIsisData #5339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
requested changes
Nov 17, 2023
isis/scripts/downloadIsisData
Outdated
| @@ -145,6 +145,11 @@ def create_rclone_arguments(destination, mission_name, parsedArgs, rclone_kwargs | |||
| excludes = [f"- {arg}" for arg in args.exclude] | |||
| filter_list.extend(excludes) | |||
|
|
|||
| if args.no_kernels: | |||
| excludes = [f"- {arg}" for arg in ['ck/**','ek/**','fk/**','ik/**','iak/**','lsk/**','mk/**','pck/**','sclk/**','spk/**']] | |||
There was a problem hiding this comment.
add: tspk/**, dsk/**,
some kernel groups have orbnum/** and old/** , and SpecialProducts/**, but we should add that to the global ignore list at the start. of the script.
AustinSanders
force-pushed
the
download_no_kernels
branch
from
c23f573 to
d5ca1bb
Compare
Kelvinrr
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "filter" and "exclude" syntax does not provide a convenient means of excluding kernels since the /kernels/ directory is part of the remote specification in the rclone configuration file. This adds a --no-kernels flag as syntax sugar to exclude any common kernel subdirectories like /ck, /fk, etc.
Related Issue
Closes #5264
How Has This Been Validated?
Ran
downloadIsisData mro ~/data/testdata --no-kernelsand verified that only calibration files were downloadedTypes of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: