Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt 5.15.8 Update #4923

Closed
wants to merge 11 commits into from
Closed

Qt 5.15.8 Update #4923

wants to merge 11 commits into from

Conversation

amystamile-usgs
Copy link
Contributor

@amystamile-usgs amystamile-usgs commented Apr 20, 2022 •
edited
Loading

Description

Updating qt to 5.15.8

The following changes are regarding the following depreciations:

1735 warnings left

  • 'QXmlDefaultHandler' is deprecated (805 warnings)
  • 'QXmlParseException' is deprecated (868 warnings)
  • 'QXmlSimpleReader' is deprecated: Use QXmlStreamReader (44 warnings)
  • 'QXmlAttributes' is deprecated (1 warning)
  • 'QXmlInputSource' is deprecated (17 warnings)
  • 'QMatrix' is deprecated: Use QTransform
  • 'endl' is deprecated: Use Qt::endl
  • 'qSort<QList>' is deprecated: Use std::sort
  • 'width' is deprecated: Use QFontMetrics::horizontalAdvance
  • 'split' is deprecated: Use Qt::SplitBehavior variant instead
  • 'QFlags' is deprecated: Use default constructor instead
  • 'lastIndexOf' is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit()
  • 'toSet' is deprecated: Use QSet(list.begin(), list.end()) instead.
  • 'fromSet' is deprecated: Use QList(set.begin(), set.end()) instead.
  • 'start' is deprecated: Use QElapsedTimer instead
  • 'elapsed' is deprecated: Use QElapsedTimer instead
  • 'toStdVector' is deprecated: Use std::vector(vector.begin(), vector.end()) instead.
  • 'qLess' is deprecated: Use std::less
  • 'null' is deprecated: use QString()
  • 'fromStdVector' is deprecated: Use QVector(vector.begin(), vector.end()) instead.
  • 'insertMulti' is deprecated: Use QMultiMap for maps storing multiple values with the same key.
  • 'primaryScreen' is deprecated: Use QGuiApplication::primaryScreen()
  • 'availableGeometry' is deprecated: Use QGuiApplication::screens()
  • 'toList' is deprecated: Use values() instead.
  • 'qVariantFromValue<Isis::Image *>' is deprecated: Use QVariant::fromValue() instead.
  • 'append' is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit()
  • 'qStableSort<QList<Isis::AbstractTreeItem *>::iterator, Isis::AbstractTableModel::LessThanFunctor>' is deprecated: Use std::stable_sort
  • 'screenGeometry' is deprecated: Use QGuiApplication::screens()
  • 'isItemSelected' is deprecated: Use QListWidgetItem::isSelected() instead
  • 'light' is deprecated: Use QColor::lighter() instead
  • 'dark' is deprecated: Use QColor::darker() instead
  • 'intersect' is deprecated: Use intersects() instead
  • 'drawRoundRect' is deprecated: Use drawRoundedRect(..., Qt::RelativeSize) instead
  • 'operator=' is deprecated: Use QDir::setPath() instead
  • 'setPageSize' is deprecated: Use setPageSize(QPageSize) instead.
  • qBinaryFind<QList::iterator, QString>' is deprecated: Use std::binary_search
  • 'qsrand' is deprecated: use QRandomGenerator instead
  • 'uniqueKeys' is deprecated: Use QMultiMap for maps storing multiple values with the same key.
  • 'values' is deprecated: Use QMultiMap for maps storing multiple values with the same key.
  • local variable 'frameMap' will be copied despite being returned by name call 'std::move' explicitly to avoid copying
  • qFind<QList<Isis::Image *>::iterator, Isis::Image *>' is deprecated: Use std::find
  • 'start' is deprecated: Use QProcess::start(const QString &program, const QStringList &arguments,OpenMode mode = ReadWrite) instead

Related Issue

#5336

Motivation and Context

Isis Dependencies Sprint

How Has This Been Tested?

Running PR against Jenkins for any test failures

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@acpaquette
Copy link
Collaborator

With regards to endl, that should be part of a standard library in C++. I guess I'm just confused why an update to Qt would deprecate endl?

@amystamile-usgs
Copy link
Contributor Author

With regards to endl, that should be part of a standard library in C++. I guess I'm just confused why an update to Qt would deprecate endl?

@acpaquette It's anytime endl is being piped into a QDebug.

@amystamile-usgs
Copy link
Contributor Author

Linux is failing the conda environment with the following incompatibilites:

The following specifications were found to be incompatible with your system:

  - feature:/linux-64::__glibc==2.27=0
  - feature:|@/linux-64::__glibc==2.27=0
  - ale=0.8.6 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - armadillo -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - blas -> libgfortran-ng -> __glibc[version='>=2.17']
  - boost-cpp=1.72 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - boost=1.72 -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - bzip2 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - cmake[version='>=3.15'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - csm[version='>=3.0.3,<3.0.4'] -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - cspice -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - curl -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - doxygen -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - eigen[version='<3.4'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - ffmpeg -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - geos[version='>=3.7,<3.8'] -> libgcc-ng[version='>=7.3.0'] -> __glibc[version='>=2.17']
  - geotiff -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - gmp -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - graphviz -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - gsl[version='>=2.6'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - hdf5 -> libgfortran-ng -> __glibc[version='>=2.17']
  - icu -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - inja -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - jpeg -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - krb5 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - libopencv[version='>=4.5.2'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - libpng[version='>=1.6.34'] -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - libprotobuf -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - libtiff[version='>=4.0'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - libxml2 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - make -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - mesalib -> __glibc[version='>=2.17,<3.0.a0']
  - mesalib -> libgcc-ng[version='>=7.3.0'] -> __glibc[version='>=2.17']
  - mysql -> libgcc-ng[version='>=7.3.0'] -> __glibc[version='>=2.17']
  - mysql-connector-c -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - nn -> libgcc-ng[version='>=7.3.0'] -> __glibc[version='>=2.17']
  - opencv[version='>=4.5.2'] -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']
  - openssl[version='>=1.1.1k'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - pcl[version='>=1.10.0'] -> vtk[version='>=9.1.0,<9.1.1.0a0'] -> __glibc[version='>=2.17|>=2.17,<3.0.a0']
  - protobuf -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - python[version='>=3.7.11'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - qhull -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - qt-main[version='>=5.15.2'] -> __glibc[version='>=2.17,<3.0.a0']
  - qwt[version='>=6.2.0'] -> __glibc[version='>=2.17,<3.0.a0']
  - qwt[version='>=6.2.0'] -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - suitesparse -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - superlu -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - swig -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - texlive-core -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - x264 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - xalan-c -> libgcc-ng[version='>=7.3.0'] -> __glibc[version='>=2.17']
  - xerces-c=3 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - xorg-kbproto -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - xorg-libice -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - xorg-libsm -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - xorg-libx11 -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - xorg-libxi -> libgcc-ng[version='>=9.3.0'] -> __glibc[version='>=2.17']
  - zlib -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']

@acpaquette
Copy link
Collaborator

@amystamile-usgs I've run into this before on updating some other package. Trying to remember why it happend

@acpaquette
Copy link
Collaborator

It seems like the issues on linux are related to the pinned version of ALE, then after that is handled libopencv cannot be solved for since there is not version of libopencv that is built with Qt 5.15. I have put an issue in with the Opencv feedstock to see if this can be updated.

conda-forge/opencv-feedstock#312

@amystamile-usgs amystamile-usgs changed the title Qt updates Qt 5.15.2 and Qwt 6.2.0 Apr 27, 2022
@jlaura
Copy link
Collaborator

jlaura commented Jun 23, 2022

@amystamile-usgs @acpaquette What is the status on this? Can we schedule this for completion or does this have outstanding external dependencies?

@acpaquette
Copy link
Collaborator

@jlaura Sorry to take so long on this, I think that the linux solve issues may be resolved? I just built an isis build environment on prog28 that picked up qt 5.15, going to confirm this. I know that there was still somethings to solve on the actual code side of things as well

@jlaura
Copy link
Collaborator

jlaura commented Jul 14, 2022

@acpaquette No worries on the timeline! Does that mean that this needs to get updated and merged, or that this was resolved external to us?

@acpaquette
Copy link
Collaborator

This is also going to run into issue with protobuf and opencv. See:
protocolbuffers/protobuf#9947

@acpaquette
Copy link
Collaborator

@jlaura This was resolved externally but it looks like we will be running into other issues from external dependencies as per my previous comment

@acpaquette
Copy link
Collaborator

@jlaura @jessemapel Supporting Ubuntu 20.04 and 22 would likely require updates to Qt that this PR has started

@jessemapel
Copy link
Contributor

#5031

@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this pull request hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this pull request will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Feb 13, 2023
@amystamile-usgs amystamile-usgs removed the inactive Issue that has been inactive for at least 6 months label Feb 21, 2023
@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this pull request hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this pull request will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Aug 21, 2023
@amystamile-usgs amystamile-usgs removed the inactive Issue that has been inactive for at least 6 months label Nov 28, 2023
@amystamile-usgs amystamile-usgs changed the title Qt 5.15.2 and Qwt 6.2.0 Qt 5.15.8 Update Nov 29, 2023
@amystamile-usgs amystamile-usgs marked this pull request as ready for review November 29, 2023 17:57
@acpaquette
Copy link
Collaborator

acpaquette commented Nov 30, 2023 •
edited
Loading

@amystamile-usgs Jenkins is failing to solve the env, we may need to change the environment file. Pinning the python version to 3.9 may be enough.

@amystamile-usgs
Copy link
Contributor Author

amystamile-usgs commented Mar 14, 2024 •
edited
Loading

Refreshing my memory on this PR. It is currently on hold because we need to rework the XML Reader/Writer. I think Adam was working on this at some point.

Accidentally removed Adam's commits with these fixes. Added them back in.

@amystamile-usgs amystamile-usgs marked this pull request as draft March 18, 2024 18:15
@amystamile-usgs
Copy link
Contributor Author

Splitting up this PR into multiple smaller PRs

@amystamile-usgs amystamile-usgs deleted the qtUpdate branch November 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acpaquette acpaquette Awaiting requested review from acpaquette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amystamile-usgs @acpaquette @jlaura @jessemapel