Mac OS 11.6 local build fixes #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scsides I don't know that we want to merge this with hard coded PATHs to a local machine. This is non-portable to any other dev. What are the alternatives? |
|
Yes I know. This is a topic I would like to discuss at the next SU. We need a standard location for the includes, or use the environment variable ability for find_package. There may be other options I'm not thinking of. |
scsides
added a commit
to scsides/ISIS3
that referenced
this pull request
Feb 11, 2022
* xalan is required for ISIS, see cmakelists.txt * Fix conda build for Mac 11.6
scsides
added a commit
that referenced
this pull request
Feb 11, 2022
* Add a list of browse records to the output rdr if they exist on the cube (#4774) * Converted TGO IngestReingest Category Test. (#4789) * Fixed disk trashing on input cube reads (#4793) * Prepwork for 7.0.0 RC1 * Cleaning up the Markdown a bit I saw that some sections had wrong section numbers as they were hardcoded instead of making use of Markdown's auto-numbering. I repaired the indents for auto-numbering to work in the first half of the document and didn't touch the 2nd half where things looked okay. * Fixed jigsaw observation mode (#4791) * Test modification * Added changelog * Revert "added custom target to copy over camera.plugin files on ninja install solves #3834 (#4769)" This reverts commit 2681ffe. * updates for conda build of 7.0 (#4783) * xalan is required for ISIS, see cmakelists.txt (#4785) * Mac OS 11.6 local build fixes (#4788) * xalan is required for ISIS, see cmakelists.txt * Fix conda build for Mac 11.6 Co-authored-by: acpaquette <[email protected]> Co-authored-by: Amy Stamile <[email protected]> Co-authored-by: Michael Aye <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: Jesse Mapel <[email protected]>
scsides
added a commit
that referenced
this pull request
Feb 11, 2022
* Add a list of browse records to the output rdr if they exist on the cube (#4774) * Converted TGO IngestReingest Category Test. (#4789) * Fixed disk trashing on input cube reads (#4793) * Prepwork for 7.0.0 RC1 * Cleaning up the Markdown a bit I saw that some sections had wrong section numbers as they were hardcoded instead of making use of Markdown's auto-numbering. I repaired the indents for auto-numbering to work in the first half of the document and didn't touch the 2nd half where things looked okay. * Fixed jigsaw observation mode (#4791) * Test modification * Added changelog * Revert "added custom target to copy over camera.plugin files on ninja install solves #3834 (#4769)" This reverts commit 2681ffe. * updates for conda build of 7.0 (#4783) * xalan is required for ISIS, see cmakelists.txt (#4785) * Mac OS 11.6 local build fixes (#4788) * xalan is required for ISIS, see cmakelists.txt * Fix conda build for Mac 11.6 * Added log entry for #4793 (#4796) Co-authored-by: acpaquette <[email protected]> Co-authored-by: Amy Stamile <[email protected]> Co-authored-by: Michael Aye <[email protected]> Co-authored-by: Jesse Mapel <[email protected]> Co-authored-by: Jesse Mapel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: