Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgocassismos App Conversion #4629

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

amystamile-usgs
Copy link
Contributor

Description

Converted tgocassismos app to prep for another tgo module gtest conversion. Breaking up changes in various PRs to reduce PR size for module test conversion.

Related Issue

Task to try to convert tgo module tests to gtests.

Motivation and Context

GNN sprint

How Has This Been Tested?

existing tests pass.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Again, I don't know what the deal with the license stuff is

isis/src/tgo/apps/tgocassismos/main.cpp Outdated Show resolved Hide resolved
isis/src/tgo/apps/tgocassismos/tgocassismos.h Show resolved Hide resolved
@amystamile-usgs amystamile-usgs merged commit d4b2343 into DOI-USGS:dev Sep 15, 2021
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Nov 8, 2021
* tgocassismos App Conversion

* added licensing to main.cpp and header.
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Nov 15, 2021
* tgocassismos App Conversion

* added licensing to main.cpp and header.
@amystamile-usgs amystamile-usgs deleted the tgocassismos branch November 19, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants